Better building and testing of deployable zipfile artifacts #8706
+286
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpears
reviewed
Jan 7, 2025
|
This is very cool, all the additions seem sensible and pointed in the right direction. Do you plan on getting the whole migration squash process in to main before merging this? |
See changes to docs/deployment.md for usage.
No need to specify pull_request types, as these are already the defaults, see: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request
chosak
force-pushed
the
feature/deployable-zipfile-images
branch
from
eec1667 to
c08cf7f
Compare
wpears
approved these changes
Jan 8, 2025
|
Thanks @wpears. I took a quick look at implementing a non-root user but it gets complicated because of necessary permissions on the mounted volume used for the cf.gov artifact. I'm going to merge this to try it out and we can add in future if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the way that we build the "deployable zipfile" artifact that gets installed on EC2 servers running cf.gov.
Currently we don't have any automated testing around the built artifact. The only way we know it works properly is when we test its deployment onto a real EC2 instance. This PR adds automated testing of the image by deploying it to a CentOS 7-based container (to mimic our current RHEL7 EC2 instances). These changes are intended to provide a framework for pending changes to our EC2 workflows around both Apache and upgrading to RHEL9.
These changes don't modify the deployable zipfile at all but only modify how it gets built. There are now two Docker images -
cfgov-artifact-builderandcfgov-artifact-tester- that are used to build and test the artifact, respectively.Note that this PR includes some manual surgery of migration files that will be unnecessary once the migration squash process started in #8701 is completed; this surgery was necessary to remove incompatibilities with SQLite which is used when testing the deployable zipfile.
Screenshots
New documentation about the modified process: